ci: use gRPC 1.36.4 in oldest-deps build
#10394
Conversation
Testing with gRPC==1.33 is untenable, as we need features only available in gRPC==1.35. Unfortunately `vcpkg` skipped gRPC 1.34 and gRPC 1.35, so we need to skip forward. That opens a gap in our test coverage, but that is better than getting stuck without any ability to make progress.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.86% // Head: 93.87% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10394 +/- ##
=======================================
Coverage 93.86% 93.87%
=======================================
Files 1601 1601
Lines 145620 145620
=======================================
+ Hits 136693 136698 +5
+ Misses 8927 8922 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @coryan)
ci/etc/oldest-deps/vcpkg.json line 21 at r1 (raw file):
{ "name": "grpc", "version>=": "1.33.1",
should this be 1.36.4? or 1.35.x ?
ci/etc/oldest-deps/vcpkg.json line 29 at r1 (raw file):
"host": true }, {"name": "grpc", "version>=": "1.33.1"},
ditto
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @dbolduc)
ci/etc/oldest-deps/vcpkg.json line 21 at r1 (raw file):
Previously, dbolduc (Darren Bolduc) wrote…
should this be 1.36.4?
TL;DR; nope.
Between 1.33.1 and 1.36.4 gRPC switched from "string versions" to "semver versions". Those are not comparable, and changing this to 1.36.4 would break the build. We could update the builtin-baseline to something that excludes gRPC 1.33.1, but that bumps the Abseil version in a weird way too, and we don't want that. Pinning the version is the only thing that works until we are ready to update most deps.
ci/etc/oldest-deps/vcpkg.json line 29 at r1 (raw file):
Previously, dbolduc (Darren Bolduc) wrote…
ditto
Done.
Testing with gRPC==1.33 is untenable, as we need features only available in gRPC==1.35. Unfortunately
vcpkgskipped gRPC 1.34 and gRPC 1.35, so we need to skip forward. That opens a gap in our test coverage, but that is better than getting stuck without any ability to make progress.Part of the work for #5915
This change is