Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support third-party identity #5915

Closed
13 tasks done
coryan opened this issue Feb 24, 2021 · 2 comments · Fixed by #10465
Closed
13 tasks done

Support third-party identity #5915

coryan opened this issue Feb 24, 2021 · 2 comments · Fixed by #10465
Assignees
@coryan
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
GUAC M3: complete...

Comments

@coryan
Copy link
Contributor

coryan commented Feb 24, 2021 •
edited by scotthart
Loading

We need to support third-party identities, like gRPC does in:

https://github.com/grpc/proposal/blob/master/L77-core-cpp-third-party-identity-support-for-call-credentials.md

More details available internally at go/guac-3pi

  • Create token source for files
  • Create token source for OIDC
  • Create token source for AWS v1
  • Implement token exchange
  • #13087
  • Add support in oauth2_internal::MapCredentials()
  • Add support in storage::oauth2::MapCredentials()
  • Add support in g::c::internal::CreateAuthenticationStrategy
  • Add support in g::c::oauth2_internal::GoogleDefaultCredentials()
  • Consider a new factory function g::c::MakeExternalAccountCredentials()
  • Manually test with Azure
  • Manually test with AWS
  • Propagate g::c::Options from factory function to the token sources and token exchange
@coryan coryan added api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 24, 2021
@coryan coryan added this to the Unified Auth Client for C++ milestone Mar 18, 2021
@coryan
Copy link
Contributor Author

coryan commented Mar 10, 2022

Still needed.

@coryan
Copy link
Contributor Author

coryan commented Aug 11, 2022

Strike 2, keep open.

@coryan coryan self-assigned this Nov 9, 2022
This was referenced Nov 16, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 28, 2022
Closed
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Dec 5, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Dec 12, 2022
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Dec 20, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
GUAC M3: complete AIP features
Development

Successfully merging a pull request may close this issue.

feat(common): factory function for external accounts coryan/google-cloud-cpp
1 participant
@coryan