Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): external account format parser #10281

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Nov 19, 2022

I will need this for other subject token sources, including URL-based ones.

Part of the work for #5915


This change is Reviewable

I will need this for other subject token sources, including URL-based
ones.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 3db16367043456d7e15452f10613825ff0d5c507

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Base: 93.84% // Head: 93.84% // No change to project coverage 👍

Coverage data is based on head (7d35ce8) compared to base (7d35ce8).
Patch has no changes to coverable lines.

❗ Current head 7d35ce8 differs from pull request most recent head 3db1636. Consider uploading reports for the commit 3db1636 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10281   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files        1575     1575           
  Lines      144311   144311           
=======================================
  Hits       135424   135424           
  Misses       8887     8887           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review November 19, 2022 21:26
@coryan coryan requested a review from a team as a code owner November 19, 2022 21:26
@coryan coryan merged commit a8b2f3c into googleapis:main Nov 20, 2022
@coryan coryan deleted the feat-oauth2-workload-identity-federation-pr5 branch November 20, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants