-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1167 +/- ##
==========================================
+ Coverage 95.7% 95.74% +0.03%
==========================================
Files 174 174
Lines 13601 13602 +1
==========================================
+ Hits 13017 13023 +6
+ Misses 584 579 -5
Continue to review full report at Codecov.
|
ad52f1d
to
df05fd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we understand why the vptr
change is not needed here? Maybe because we do not define any gRPC servers?
Reviewed 2 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
In the bigtable library we use/pass arguments of type
In spanner, we only use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
df05fd7
to
e80992c
Compare
FWIW, the 1.26.x branch allegedly has fixes for the problems you are seeing. |
This looks like it is probably obsolete after the recent merge of #1232. |
This change is