-
Notifications
You must be signed in to change notification settings - Fork 14
[Flake] Windows build failed with segfault #1034
Comments
Oh I see segfault two times in a row |
Something similar is currently a problem.
|
This happens a lot. Seems like every PR. Note: That once we have a dep on Abseil, there are some flags that we can set that will enable stack traces: To quote from @derekmauro
|
6 tries (at 20 minutes a pop, plus the extra delay of having to notice and push the button) to get this to pass... regardless of not getting stack traces, seems like we should temporarily disable |
For what it is worth, I am running the integration tests in a Windows VM. It is not just
|
That's a different issue though (#923), and seems to happen much less frequently. The ones I (and others) have been seeing lhere ook like:
this does happen in other tests (takashi's original report is in this case, there's no sign of the |
@mr-salty You are right of course sorry, I was confused. I ran that program under a debugger (stack trace at the bottom). The last call in our code is:
started from this code in the benchmark: google-cloud-cpp-spanner/google/cloud/spanner/benchmarks/multiple_rows_cpu_benchmark.cc Line 705 in c872116
I will run it a couple more times to see if it always crashes in the same spot.
|
Second run, crashes in the same point, but very different stack trace:
|
Third run, similar stack trace:
|
It might be related to grpc/grpc#18461, that is fixed in 1.25.x, and we are currently using 1.23.x in the CMake+Windows builds. |
The workaround suggested in grpc/grpc#18461 (comment) seems to work for now. |
How that this is under control, and we know what the fix is, I think P2 is a more reasonable priority. |
FWIW, the Windows CI builds are upgraded to gRPC-1.26.0. We may be able to disable the workaround in #1158 |
Actually, only the CMake builds for Windows are updated to gRPC-1.26.0. The upgrade for Bazel is in progress (see #1167). |
I am not actively working on this, we need to wait to see if it repeats. Close by 2020-05-01 if it does not repeat. |
Has not repeated for 3 months, closing. |
https://source.cloud.google.com/results/invocations/ec1ef760-9a66-4f4d-825e-96cbbcefb146/targets
The sample encountered segfault.
The text was updated successfully, but these errors were encountered: