Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

ci: workaround a bug in gRPC < 1.15.0 #1158

Merged
merged 2 commits into from
Dec 18, 2019
Merged

ci: workaround a bug in gRPC < 1.15.0 #1158

merged 2 commits into from
Dec 18, 2019

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 18, 2019

Before 1.25.0 gRPC sometimes crashes when using the c-ares DNS resolver
on Windows, see grpc/grpc#18461 for more details.

I think this will minimize the problems reported in #1034


This change is Reviewable

Before 1.25.0 gRPC sometimes crashes when using the c-ares DNS resolver
on Windows, see grpc/grpc#18461 for more details.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 18, 2019
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #1158 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1158      +/-   ##
==========================================
- Coverage   95.76%   95.74%   -0.03%     
==========================================
  Files         170      170              
  Lines       13159    13163       +4     
==========================================
+ Hits        12602    12603       +1     
- Misses        557      560       +3
Impacted Files Coverage Δ
...on_tests/rpc_failure_threshold_integration_test.cc 85.71% <0%> (-2.07%) ⬇️
google/cloud/spanner/client.cc 96.55% <0%> (-0.87%) ⬇️
google/cloud/spanner/samples/samples.cc 86.37% <0%> (ø) ⬆️
google/cloud/spanner/internal/time_format.cc 100% <0%> (ø) ⬆️
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 92.87% <0%> (ø) ⬆️
google/cloud/spanner/value.h 92.8% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c872116...2bfaf31. Read the comment docs.

@coryan coryan marked this pull request as ready for review December 18, 2019 18:05
@coryan coryan merged commit ff50b65 into googleapis:master Dec 18, 2019
@coryan coryan deleted the workaround-grpc-cares-crash branch December 18, 2019 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants