Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Use PaginationRange from g-c-cpp-common #1256

Closed
coryan opened this issue Feb 10, 2020 · 0 comments · Fixed by #1278
Closed

Use PaginationRange from g-c-cpp-common #1256

coryan opened this issue Feb 10, 2020 · 0 comments · Fixed by #1278
Assignees
@devjgm
Labels
api: spanner Issues related to the googleapis/google-cloud-cpp-spanner API. type: cleanup An internal cleanup or hygiene concern.

Comments

@coryan
Copy link
Contributor

coryan commented Feb 10, 2020

I am preparing a PR to copy the code (see googleapis/google-cloud-cpp-common#168), this is a reminder to remove the code from this repository, leave the header and a type alias for backwards compatibility.
@coryan coryan added the type: cleanup An internal cleanup or hygiene concern. label Feb 10, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/google-cloud-cpp-spanner API. label Feb 10, 2020
@devjgm devjgm self-assigned this Feb 21, 2020
devjgm added a commit to devjgm/google-cloud-cpp-spanner that referenced this issue Feb 21, 2020
@devjgm
cleanup: use common's PaginationRange
5f9dd39 
Deletes our own internal/range_from_pagination.h
Fixes: googleapis#1256
@devjgm devjgm mentioned this issue Feb 21, 2020
Merged
devjgm added a commit that referenced this issue Feb 21, 2020
@devjgm
cleanup: use common's PaginationRange (#1278)
9572c85 
Deletes our own internal/range_from_pagination.h
Fixes: #1256
devjgm added a commit to devjgm/google-cloud-cpp that referenced this issue May 7, 2020
@devjgm
cleanup: use common's PaginationRange (googleapis/google-cloud-cpp-sp…
0f8ef35 
…anner#1278)

Deletes our own internal/range_from_pagination.h
Fixes: googleapis/google-cloud-cpp-spanner#1256
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devjgm devjgm

Labels
api: spanner Issues related to the googleapis/google-cloud-cpp-spanner API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup: use common's PaginationRange devjgm/google-cloud-cpp-spanner
2 participants
@coryan @devjgm