This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
refactor: copy PaginationRange from spanner #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
==========================================
+ Coverage 96.2% 96.22% +0.01%
==========================================
Files 92 94 +2
Lines 4248 4395 +147
==========================================
+ Hits 4087 4229 +142
- Misses 161 166 +5
Continue to review full report at Codecov.
|
devjgm
reviewed
Feb 10, 2020
coryan
commented
Feb 10, 2020
There was a problem hiding this comment.
There are two .bzl files changed, but no new .bzl files:
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @devbww, @mr-salty, and @scotthart)
devjgm
approved these changes
Feb 10, 2020
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Apr 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is