This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
fix: docker image caching #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 82 82
Lines 3660 3660
=======================================
Hits 3527 3527
Misses 133 133Continue to review full report at Codecov.
|
mr-salty
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @devbww, @devjgm, @mr-salty, and @scotthart)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ci/kokoro/docker/Dockerfile.ubuntu-installfile had a bug that would cause theimage rebuild to fail: it ran with
-j <nothing>which launches too many compilerinstances, they crash, and the build would fail.
In addition to making the build too slow, this stopped the Docker image cache from
being refreshed. Which kept the build slow. And for extra fun it caused the CheckAPI
fixes that @mr-salty made in #139 not work.
I think this fixes #137
This change is