This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
chore: update the API/ABI dump #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the broken API checking build. Note that #134 did make a breaking change (changing the return type for `MakeDeadlineTimer` and `MakeRelativeTimer`), but that didn't cause the build to fail - it's listed as "Low Severity" OTOH #136 changed symbols in the `internal` namespace only, and that did cause a failure. There are some other changes represented here as well (#127 at least). ``` ================ cmake-out/ci-ubuntu-install-18.04-update-api/compat_reports/google_cloud_cpp_grpc_utils/reference_to_current/src_compat_report.html ================ Source compatibility report for the libgoogle_cloud_cpp_grpc_utils.so object between reference and current versions Test Info ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Module Name google_cloud_cpp_grpc_utils Version #1 reference Version #2 current Arch x86_64 Test Results ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Total Header Files 14 Total Source Files 4 Total Objects 1 Total Symbols / Types 54 / 16 Compatibility 91.7% Problem Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Severity Count Added Symbols - 5 Removed Symbols High 6 Problems with High 0 Data Types Medium 0 Low 0 Problems with High 0 Symbols Medium 3 Low 2 Problems with Low 0 Constants Added Symbols 5 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ completion_queue.h namespace google::cloud::grpc_utils::v0 CompletionQueue::CancelAll ( ) _ZN6google5cloud10grpc_utils2v015CompletionQueue9CancelAllEv completion_queue_impl.h namespace google::cloud::grpc_utils::v0::internal CompletionQueueImpl::CancelAll ( ) _ZN6google5cloud10grpc_utils2v08internal19CompletionQueueImpl9CancelAllEv CompletionQueueImpl::Run ( ) _ZN6google5cloud10grpc_utils2v08internal19CompletionQueueImpl3RunEv CompletionQueueImpl::SimulateCompletion ( bool ok ) _ZN6google5cloud10grpc_utils2v08internal19CompletionQueueImpl18SimulateCompletionEb CompletionQueueImpl::SimulateCompletion ( google::cloud::grpc_utils::v0::AsyncOperation* op, bool ok ) _ZN6google5cloud10grpc_utils2v08internal19CompletionQueueImpl18SimulateCompletionEPNS2_14AsyncOperationEb to the top Removed Symbols 6 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ completion_queue.h namespace grpc CompletionQueue::~CompletionQueue [D0] ( ) _ZN4grpc15CompletionQueueD0Ev CompletionQueue::~CompletionQueue [D1] ( ) _ZN4grpc15CompletionQueueD1Ev CompletionQueue::~CompletionQueue [D2] ( ) _ZN4grpc15CompletionQueueD2Ev completion_queue_impl.h namespace google::cloud::grpc_utils::v0::internal CompletionQueueImpl::Run ( google::cloud::grpc_utils::v0::CompletionQueue& cq ) _ZN6google5cloud10grpc_utils2v08internal19CompletionQueueImpl3RunERNS2_15CompletionQueueE CompletionQueueImpl::SimulateCompletion ( google::cloud::grpc_utils::v0::CompletionQueue& cq, bool ok ) _ZN6google5cloud10grpc_utils2v08internal19CompletionQueueImpl18SimulateCompletionERNS2_15CompletionQueueEb CompletionQueueImpl::SimulateCompletion ( google::cloud::grpc_utils::v0::CompletionQueue& cq, google::cloud::grpc_utils::v0::AsyncOperation* op, bool ok ) _ZN6google5cloud10grpc_utils2v08internal19CompletionQueueImpl18SimulateCompletionERNS2_15CompletionQueueEPNS2_14AsyncOperationEb to the top Problems with Symbols, Medium Severity 3 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ completion_queue_impl.h namespace google::cloud::grpc_utils::v0::internal [+] CompletionQueueImpl::Run ( google::cloud::grpc_utils::v0::CompletionQueue& cq ) 1 ⇣ CompletionQueueImpl::Run ( ) _ZN6google5cloud10grpc_utils2v08internal19CompletionQueueImpl3RunERNS2_15CompletionQueueE Change Effect 1 Parameters list has been Recompilation of a client program may be changed. broken. [+] CompletionQueueImpl::SimulateCompletion ( google::cloud::grpc_utils::v0::CompletionQueue& cq, bool ok ) 1 ⇣ CompletionQueueImpl::SimulateCompletion ( bool ok ) _ZN6google5cloud10grpc_utils2v08internal19CompletionQueueImpl18SimulateCompletionERNS2_15CompletionQueueEb Change Effect 1 Parameters list has been Recompilation of a client program may be changed. broken. [+] CompletionQueueImpl::SimulateCompletion ( google::cloud::grpc_utils::v0::CompletionQueue& cq, google::cloud::grpc_utils::v0::AsyncOperation* op, bool ok ) 1 ⇣ CompletionQueueImpl::SimulateCompletion ( bool ok ) _ZN6google5cloud10grpc_utils2v08internal19CompletionQueueImpl18SimulateCompletionERNS2_15CompletionQueueEPNS2_14AsyncOperationEb Change Effect 1 Parameters list has been Recompilation of a client program may be changed. broken. to the top Problems with Symbols, Low Severity 2 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ completion_queue.h namespace google::cloud::grpc_utils::v0 [+] CompletionQueue::MakeDeadlineTimer ( std::chrono::_V2::system_clock::time_point deadline ) 1 _ZN6google5cloud10grpc_utils2v015CompletionQueue17MakeDeadlineTimerENSt6chrono10time_pointINS4_3_V212system_clockENS4_8durationIlSt5ratioILl1ELl1000000000EEEEEE Change Effect Type of return value has been changed from google::cloud::v0::future<std::chrono::time_point <std::chrono::_V2::system_clock, std::chrono::duration<long, Recompilation std::ratio<8 byte block:01 00 00 00 00 00 00 00, 8 byte of a client 1 block:00 ca 9a 3b 00 00 00 00> > > > to program may google::cloud::v0::future<google::cloud::v0::StatusOr be broken. <std::chrono::time_point<std::chrono::_V2::system_clock, std::chrono::duration<long, std::ratio<8 byte block:01 00 00 00 00 00 00 00, 8 byte block:00 ca 9a 3b 00 00 00 00> > > > >. completion_queue_impl.h namespace google::cloud::grpc_utils::v0::internal [+] CompletionQueueImpl::cq ( ) 1 _ZN6google5cloud10grpc_utils2v08internal19CompletionQueueImpl2cqEv Change Effect Base type of return value has been changed from Recompilation of a client 1 grpc::CompletionQueue to grpc_impl::CompletionQueue program may be broken. . to the top Header Files 14 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ async_operation.h completion_queue.h completion_queue_impl.h expect_future_error.h filesystem.h future_base.h future_generic.h future_impl.h future_then_impl.h future_void.h grpc_error_delegate.h make_unique.h status.h version.h to the top Source Files 4 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ completion_queue.cc completion_queue_impl.cc grpc_error_delegate.cc version.cc to the top Objects 1 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ libgoogle_cloud_cpp_grpc_utils.so.0.1.0 to the top ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Generated by ABI Compliance Checker 2.2 ================ cmake-out/ci-ubuntu-install-18.04-update-api/compat_reports/google_cloud_cpp_common/reference_to_current/src_compat_report.html ================ Source compatibility report for the libgoogle_cloud_cpp_common.so object between reference and current versions Test Info ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Module Name google_cloud_cpp_common Version #1 reference Version #2 current Arch x86_64 Test Results ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Total Header Files 21 Total Source Files 16 Total Objects 1 Total Symbols / Types 121 / 33 Compatibility 100% Problem Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Severity Count Added Symbols - 1 Removed Symbols High 0 Problems with High 0 Data Types Medium 0 Low 0 Problems with High 0 Symbols Medium 0 Low 0 Problems with Low 0 Constants Added Symbols 1 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ version.h namespace google::cloud::v0 version_string ( ) _ZN6google5cloud2v014version_stringB5cxx11Ev to the top Header Files 21 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ backoff_policy.h big_endian.h build_info.h compiler_info.h expect_future_error.h filesystem.h format_time_point.h future_impl.h getenv.h iam_binding.h iam_bindings.h iam_policy.h log.h make_unique.h optional.h parse_rfc3339.h random.h setenv.h status.h terminate_handler.h throw_delegate.h to the top Source Files 16 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ backoff_policy.cc build_info.cc compiler_info.cc filesystem.cc format_time_point.cc future_impl.cc getenv.cc iam_bindings.cc iam_policy.cc log.cc parse_rfc3339.cc random.cc setenv.cc status.cc terminate_handler.cc throw_delegate.cc to the top Objects 1 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ libgoogle_cloud_cpp_common.so.0.12.0 to the top ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Generated by ABI Compliance Checker 2.2 ```
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 82 82
Lines 3660 3660
=======================================
Hits 3527 3527
Misses 133 133Continue to review full report at Codecov.
|
|
Something is not quite right, the build failed. I am trying to update the baseline myself in case there is some weirdness going on. |
|
FWIW, this is failing because the CI build is using an ancient Docker image (circa 2019-10), and it won't pick any updates due to the problems described in #137. |
coryan
added a commit
that referenced
this pull request
Jan 29, 2020
The `ci/kokoro/docker/Dockerfile.ubuntu-install` file had a bug that would cause the image rebuild to fail: it ran with `-j <nothing>` which launches too many compiler instances, they crash, and the build would fail. In addition to making the build too slow, this stopped the Docker image cache from being refreshed. Which kept the build slow. And for extra fun it caused the CheckAPI fixes that @mr-salty made in #139 not work.
|
I am closing this because #141 also fixed the baseline. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the broken API checking build.
Note that #134 did make a breaking change (changing the return type for
MakeDeadlineTimerandMakeRelativeTimer), but that didn't cause thebuild to fail - it's listed as "Low Severity"
OTOH #136 changed symbols in the
internalnamespace only, and that didcause a failure.
There are some other changes represented here as well (#127 at least).
This change is