feat(aip-136): response message name

rules/aip0136/response_message_name.go

@@ -48,17 +48,11 @@ var responseMessageName = &lint.MethodRule{
 
 		response := utils.GetResponseType(m)
 		requestResourceType := utils.GetResourceReference(m.GetInputType().FindFieldByName("name")).GetType()
-
-		// If we can't determine if this is a resource-based custom method return the
-		// findings from the above matching response name lint
-		if !utils.IsResource(response) || requestResourceType == "" {
-			return suffixFindings
-		}
+		responseResourceType := utils.GetResource(response).GetType()
 
 		// However, if we can determine that this is a resource-based custom method,
 		// the ensure that they equal
-		responseResourceType := utils.GetResource(response).GetType()
-		if responseResourceType == requestResourceType {
+		if utils.IsResource(response) && responseResourceType == requestResourceType {
 			return nil
 		}
 

rules/aip0136/response_message_name_test.go

@@ -30,7 +30,8 @@ func TestResponseMessageName(t *testing.T) {
 			problems        testutils.Problems
 		}{
 			{"Valid", "ArchiveBook", "ArchiveBookResponse", testutils.Problems{}},
-			{"Invalid", "ArchiveBook", "ArchiveBookResp", testutils.Problems{{Suggestion: "ArchiveBookResponse"}}},
+			{"Invalid", "ArchiveBook", "ArchiveBookResp", testutils.Problems{{
+				Message: "Custom methods should return a message matching the RPC name, with a `Response` suffix, or the resource being operated on, not \"ArchiveBookResp\"."}}},
 		}
 
 		for _, test := range tests {