Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aip-136): response message name #1387

Merged
merged 10 commits into from
May 17, 2024
Merged

feat(aip-136): response message name #1387

merged 10 commits into from
May 17, 2024
+347 −0

Commits on May 15, 2024

  1. feat(aip-0136): response message name 

    This patch implements the guidelines around the response message
name for custom methods

Ref: https://google.aip.dev/136
    @liveFreeOrCode
    liveFreeOrCode committed May 15, 2024
    Configuration menu
    Copy the full SHA
    62a90e5 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge branch 'main' into aip-0136-response-message-name

    @liveFreeOrCode
    liveFreeOrCode committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5e2ddf1 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. fix(AIP-136): improve logic

    @liveFreeOrCode
    liveFreeOrCode committed May 17, 2024
    Configuration menu
    Copy the full SHA
    ba25dab View commit details
    Browse the repository at this point in the history

  2. fix(AIP-136): clean up resource test template

    @liveFreeOrCode
    liveFreeOrCode committed May 17, 2024
    Configuration menu
    Copy the full SHA
    bd4a2f9 View commit details
    Browse the repository at this point in the history

  3. Update docs/rules/0136/response-message-name.md 

    Co-authored-by: Noah Dietz <[email protected]>
    @liveFreeOrCode @noahdietz
    liveFreeOrCode and noahdietz authored May 17, 2024
    Configuration menu
    Copy the full SHA
    36d1493 View commit details
    Browse the repository at this point in the history

  4. Update docs/rules/0136/response-message-name.md 

    Co-authored-by: Noah Dietz <[email protected]>
    @liveFreeOrCode @noahdietz
    liveFreeOrCode and noahdietz authored May 17, 2024
    Configuration menu
    Copy the full SHA
    cfd6056 View commit details
    Browse the repository at this point in the history

  5. chore(AIP-136): PR feedback

    @liveFreeOrCode
    liveFreeOrCode committed May 17, 2024
    Configuration menu
    Copy the full SHA
    b007953 View commit details
    Browse the repository at this point in the history

  6. fix: always return appropriate error message

    @liveFreeOrCode
    liveFreeOrCode committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c28fca7 View commit details
    Browse the repository at this point in the history

  7. fix: comment candy

    @liveFreeOrCode
    liveFreeOrCode committed May 17, 2024
    Configuration menu
    Copy the full SHA
    8bd648c View commit details
    Browse the repository at this point in the history

  8. chore: pr feedback to cleanup test message diff

    @liveFreeOrCode
    liveFreeOrCode committed May 17, 2024
    Configuration menu
    Copy the full SHA
    3eb6784 View commit details
    Browse the repository at this point in the history