Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AIP-136): disable http-name-variable and http-parent-variable #1040

Merged
merged 2 commits into from
Nov 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/rules/0136/http-name-variable.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ redirect_from:
- /0136/http-name-variable
---

**Important:** This rule has been temporarily disabled as it does not match any
AIP guidance. See discussion [here][https://github.com/aip-dev/google.aip.dev/issues/955].

# Custom methods: HTTP name variable

This rule enforces that custom methods only use the `name` variable if the RPC
Expand Down
3 changes: 3 additions & 0 deletions docs/rules/0136/http-parent-variable.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ redirect_from:
- /0136/http-parent-variable
---

**Important:** This rule has been temporarily disabled as it does not match any
AIP guidance. See discussion [here][https://github.com/aip-dev/google.aip.dev/issues/955].

# Custom methods: HTTP parent variable

This rule enforces that custom methods only use the `parent` variable if the
Expand Down
6 changes: 4 additions & 2 deletions rules/aip0136/aip0136.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,14 @@ func AddRules(r lint.RuleRegistry) error {
136,
httpBody,
httpMethod,
httpNameVariable,
httpParentVariable,
noPrepositions,
standardMethodsOnly,
uriSuffix,
verbNoun,
// These rules are disabled as they have no matching AIP guidance.
// See https://github.com/aip-dev/google.aip.dev/issues/955 for details.
// httpNameVariable,
// httpParentVariable,
)
}

Expand Down