Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AIP-136): disable http-name-variable and http-parent-variable #1040

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

noahdietz
Copy link
Collaborator

Disable the AIP-136 rules http-name-variable and http-parent-variable after discussion on aip-dev/google.aip.dev#955 identified that these rules were insufficient and not tied to specific guidance.

Fixes #1023 by disabling it.

Note: The rule documentation has a notice that will be highlighted/formatted to stand out.

@noahdietz noahdietz requested a review from a team as a code owner November 1, 2022 16:11
@noahdietz noahdietz added the automerge Summon MOG for automerging label Nov 1, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0e871f9 into googleapis:main Nov 1, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core::136::http-name-variable enforces guidance apparently not in AIP-136
2 participants