Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed pip parse_requirments #524

Merged
merged 18 commits into from
May 8, 2020
Merged

Removed pip parse_requirments #524

merged 18 commits into from
May 8, 2020

Conversation

alimez
Copy link
Contributor

@alimez alimez commented May 5, 2020

fixes #519

@aarontp
Copy link
Member

aarontp commented May 7, 2020

@alimez : LMK when you've tested this with pinned dependencies as discussed out of band.

@alimez
Copy link
Contributor Author

alimez commented May 7, 2020

@aarontp Tested requirements pinning in a separate virtualenv and downloaded all the requirements successfully. PTAL

Copy link
Member

@aarontp aarontp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aarontp aarontp merged commit b8b2faf into google:master May 8, 2020
aarontp pushed a commit that referenced this pull request May 8, 2020
* Added Photorec task to Turbinia.

* Formatting fixes.

* Added photorec_test and made minor changes.

* Minor changes to photorec.py

* Minor changes to photorec

* Revert to initial command.

* Fixed some nits.

* Added Jupyter Notebook analysis task.

* Cleaned formmating

* Corrected formatting

* Fixed the comments/made small changes.

* Delete .gitignore

* Corrected formatting

* Added checks for job whitelist/blacklist

* Fixed formatting

* Fixed pip20.1 issue with internal imports

* removed unwanted files
@alimez alimez deleted the pip-fix branch May 8, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turbinia's setup.py seems to be broken with the latest version of pip
2 participants