-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed pip parse_requirments #524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alimez : LMK when you've tested this with pinned dependencies as discussed out of band. |
@aarontp Tested requirements pinning in a separate virtualenv and downloaded all the requirements successfully. PTAL |
aarontp
approved these changes
May 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
aarontp
pushed a commit
that referenced
this pull request
May 8, 2020
* Added Photorec task to Turbinia. * Formatting fixes. * Added photorec_test and made minor changes. * Minor changes to photorec.py * Minor changes to photorec * Revert to initial command. * Fixed some nits. * Added Jupyter Notebook analysis task. * Cleaned formmating * Corrected formatting * Fixed the comments/made small changes. * Delete .gitignore * Corrected formatting * Added checks for job whitelist/blacklist * Fixed formatting * Fixed pip20.1 issue with internal imports * removed unwanted files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #519