Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parse_dependencies from setup.py #492

Closed
aarontp opened this issue Feb 7, 2020 · 5 comments
Closed

Remove parse_dependencies from setup.py #492

aarontp opened this issue Feb 7, 2020 · 5 comments

Comments

@aarontp
Copy link
Member

aarontp commented Feb 7, 2020

It looks like the pip API changed in recent versions and parse_requirements() is not supported as it is an internal only method.

Here are a couple related issues:
pypa/pip#5599
pypa/pip#7645

Part of the stacktrace:

    Traceback (most recent call last):
      File "setup.py", line 29, in <module>
        from pip._internal.download import PipSession
    ModuleNotFoundError: No module named 'pip._internal.download'
    
    During handling of the above exception, another exception occurred:
    
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "setup.py", line 32, in <module>
        from pip.download import PipSession
    ModuleNotFoundError: No module named 'pip.download'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Here's the pip documentation linked from one of the bugs:
https://pip.pypa.io/en/stable/user_guide/#using-pip-from-your-program

@aarontp
Copy link
Member Author

aarontp commented Feb 7, 2020

Looks like Timesketch has a similar issue, but Plaso/dftimewolf use different mechanisms.
google/timesketch#1094

@loganbek
Copy link

loganbek commented Feb 7, 2020

hitting similar.

@aarontp
Copy link
Member Author

aarontp commented Feb 7, 2020

Temporary fix is in #493, and I'll patch it into the release branch and cut a release later today.

@aarontp
Copy link
Member Author

aarontp commented Feb 8, 2020

Release branch and new release pushed. Will keep this open to track a longer term fix to remove using pip from setuptools at all.

@aarontp aarontp changed the title pip install fails Remove parse_dependencies from setup.py Feb 8, 2020
@aarontp
Copy link
Member Author

aarontp commented May 12, 2020

This was fixed in #524

@aarontp aarontp closed this as completed May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants