Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run analyzers only once per timeline #2883

Merged
merged 6 commits into from
Sep 7, 2023
Merged

Run analyzers only once per timeline #2883

merged 6 commits into from
Sep 7, 2023

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Sep 7, 2023

  • Update the analyzer backend to not run an analyzer on the same timeline again by default, if the timeline was not updated and the analyzer configuration did not change.
  • Update to the analyzer frontend, to let people force another run of the analyzer.
  • This update will save plenty of celery task resources, since especially multi analyzers like the feature extractor are now only run once and not every time some other analyzer depends on them.

Closing issues
closes #2871

@jkppr jkppr requested a review from berggren September 7, 2023 12:22
@jkppr jkppr self-assigned this Sep 7, 2023
@jkppr jkppr changed the title 2871 analyzer rerun Run analyzers only once per timeline Sep 7, 2023
berggren
berggren approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@berggren berggren left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small request to add a comment.

  • fix the linter errors.

timesketch/lib/tasks.py Show resolved Hide resolved
@jkppr jkppr merged commit fb58140 into google:master Sep 7, 2023
24 checks passed
@jkppr jkppr deleted the 2871_analyzer_rerun branch September 13, 2023 09:37
@jkppr jkppr mentioned this pull request Nov 23, 2023
Closed
@jkppr jkppr mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berggren berggren berggren approved these changes

Assignees

@jkppr jkppr

Labels
Analyzers Backend Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run analyzers only when not run yet.
2 participants
@jkppr @berggren