Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Timesketch API client "run_analyzers" "ignore_previous" handling #2995

Closed
jkppr opened this issue Nov 23, 2023 · 0 comments · Fixed by #3037
Closed

Update Timesketch API client "run_analyzers" "ignore_previous" handling #2995

jkppr opened this issue Nov 23, 2023 · 0 comments · Fixed by #3037
Assignees
Labels
API client Bug Code Health Code health improvements

Comments

@jkppr
Copy link
Collaborator

jkppr commented Nov 23, 2023

Currently the Timesketch API client is handling if an analyzer should be run again or not ("ignore_previous" flag). However, with PR#2883 we moved this functionality into the server side API endpoint to also have the UI etc. benefit from this functionality.

Therefore, even setting ignore_previous=True in the API client does not have any effect since the server will still not run it which can lead to unexpected behaviour on the client side. (https://github.com/google/timesketch/blob/master/api_client/python/timesketch_api_client/timeline.py#L184C14-L184C14)

TODO: Update the API client to work with the server side checks for ignore_previous with breaking as little as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API client Bug Code Health Code health improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant