Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pull request template discouraging contributions #634

Merged
merged 3 commits into from
Apr 12, 2021
+13 −0
Merged

add pull request template discouraging contributions #634

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f854eb0
Merge pull request #1 from google/gh-pages
elharo Apr 8, 2021
103ea74
add pull request template discouraging contributions
Apr 8, 2021
aa19fd7
allow for typo corrections
Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
These style guides are copies of Google's internal style guides to
assist developers working on Google owned and originated open source
projects. Changes should be made to the internal style guide first and
only then copied here.

Unsolicited pull requests are not accepted and will be closed without
comment.

If this PR does anything other than update a style guide with changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My one problem with this text is that we've received meaningful QA-like feedback on the Python style guide via both issues and PRs. typo fixes and broken links or references to internal sections that are omitted, etc.

I don't mind if people point those out. I'm not going to merge the PR. But sometimes it's the easiest way to communicate the flaw that we need to fix internally for an eventual push.

(otherwise i'm in agreement with the overall theme that we don't accept external contributions to the guides)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I revised this a bit to allow for notification of minor errors.

already made to the internal copy, please do not create it.