add pull request template discouraging contributions #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpshead
reviewed
Apr 8, 2021
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| Unsolicited pull requests are not accepted and will be closed without | ||
| comment. | ||
|
|
||
| If this PR does anything other than update a style guide with changes |
There was a problem hiding this comment.
My one problem with this text is that we've received meaningful QA-like feedback on the Python style guide via both issues and PRs. typo fixes and broken links or references to internal sections that are omitted, etc.
I don't mind if people point those out. I'm not going to merge the PR. But sometimes it's the easiest way to communicate the flaw that we need to fix internally for an eventual push.
(otherwise i'm in agreement with the overall theme that we don't accept external contributions to the guides)
There was a problem hiding this comment.
I revised this a bit to allow for notification of minor errors.
lesv
approved these changes
Apr 9, 2021
tituswinters
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tituswinters @lesv