Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: expand build matrix for major OS #490

Merged
merged 6 commits into from
Sep 22, 2024
Merged

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Mar 11, 2024

I suggest including testing on Mac and Win.
also, the addition of OS builds does not need to be so extensive and could be listed in the include section adding 3.8 as the oldest and 3.12 as the latest python version

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <[email protected]>
@Borda Borda requested a review from hugovk April 26, 2024 12:14
@Borda
Copy link
Contributor Author

Borda commented Apr 26, 2024

@dbieber, mind having a look and sharing your thoughts? 🦩

@Borda
Copy link
Contributor Author

Borda commented Jul 14, 2024

@dbieber friendly ping if you could have a look... 🐿️

@dbieber
Copy link
Member

dbieber commented Sep 20, 2024

I'm open to this!

@Borda
Copy link
Contributor Author

Borda commented Sep 20, 2024

I'm open to this!

@dbieber updated and resolved conflicts

@dbieber
Copy link
Member

dbieber commented Sep 21, 2024

I'm seeing this error

[Invalid workflow file: .github/workflows/build.yml#L18](https://github.com/google/python-fire/actions/runs/10973863694/workflow)
The workflow is not valid. .github/workflows/build.yml (Line: 18, Col: 20): Unexpected value 'false'

@Borda
Copy link
Contributor Author

Borda commented Sep 21, 2024

I'm seeing this error

Let's go with @hugovk
@dbieber if I won't need approval for each run, it would be great (faster)

@dbieber
Copy link
Member

dbieber commented Sep 21, 2024

@dbieber if I won't need approval for each run, it would be great (faster)

It should run without approval now. 👍

.github/workflows/build.yml Outdated Show resolved Hide resolved
@dbieber dbieber merged commit a0cb1ca into google:master Sep 22, 2024
14 checks passed
@Borda Borda deleted the ci/builds branch September 22, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants