-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: watcher for automerge #435
base: master
Are you sure you want to change the base?
Conversation
now we could set these two as required checks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Copybara is the tool we use to sync the google internal copy of the repo with the github copy. The error could be from them getting out of sync; I'll have to look into that. You can ignore that check in the mean time. |
@dbieber how is it going? 🐿️ |
@dbieber can I help with anything else here? 🐰 |
Thanks for checking back in, but unfortunately no, no updates on my end. |
Gentle ping @dbieber 🐿️ |
@dbieber how are you doing, still with this project? 🐿️ |
hello @dbieber, happy New year! 🎆 |
@dbieber any chance to get some more details on what is happening with the |
Hmm, I don't know offhand. Copybara is a tool we use to sync our internal and external codebases. I'll have to investigate. |
lets try just restart it for now? |
You can safely ignore it. |
the rest is green 🟢 |
@dbieber, so can we merge it? 🤔 |
Hi Borda, Thank you for the PR and your patience. I see the value of running the GitHub Actions on a pull_request. I do not see the value of the watcher job or auto-merge, however. I understand that the watcher job would allow for auto-merge. Perhaps I am misunderstanding what auto-merge is, but it seems to me that I would like to review and approve PRs before they are merged, and hence I do not want to enable auto-merge on this project. Let me know if I'm misunderstanding auto-merge or missing something. Cheers, 🐙 |
That is probably a misunderstanding; the watcher jobs just aggregated the result over the previously completed matrix of jobs... so the case is that in the GH setting you do not need to click all jobs one by one and if you change Python version it need to be also updated in the setting but you set as required only this one which is aggregated result of all |
Co-authored-by: Hugo van Kemenade <[email protected]>
@dbieber friendly ping if you could have a look... 🐿️ |
@dbieber after the extended build matrix this gain its value as so safety you can set this watcher as required check and so all builds are required but without the need to name them one by one... |
mind check this one, and also add this rather to required checks? |
As discussed in #428 (comment) adding a closure job would allow enabling automerge without need of updating branch protection checks when new Python version is added