Update the tutorials. #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Follow-up to google#190: Set an explicit stack resolver, now that proto-lens and friends are back in nightly. - Fix some broken cross-links. - Now that google#171 is fixed, merge the `person` tutorial into a single package (a library with `Proto.*` modules and an executable that uses them) and make the instructions in the README match the code.
blackgnezdo
approved these changes
May 10, 2018
| @@ -10,8 +10,8 @@ | |||
| 6. [Repeated](#repeated) | |||
| 7. [Map](#map) | |||
| 8. [Lens Laws](#lens-laws) | |||
| 9. [Example: Person](./person/README.md) | |||
| 10. [Example: Coffee Order](./coffee-order/README.md) | |||
| 9. [Example: Person](https://github.com/google/proto-lens/tree/master/proto-lens-tutorial/person) | |||
There was a problem hiding this comment.
https://google.github.io isn't working for this?
There was a problem hiding this comment.
I tested it out; it doesn't work because the file isn't under the "docs" folder.
Also, I feel it's helpful to link to the concrete code example (especially now that they're the same).
It's not actually needed for Cabal-2.0 (lts-10 or later). But we still have CI for older versions, and it's worth confirming that the example still works on older versions.
judah
added a commit
that referenced
this pull request
Aug 25, 2018
Turns out the Travis script wasn't robust enough and #195 let through some warnings. I fixed the script and confirmed it now catches such issues. Also bumped the tutorial and bootstrap scripts to the same LTS as the main build.
judah
added a commit
that referenced
this pull request
Aug 25, 2018
Also update `stack.yaml` to `lts-12.6` rather than a nightly. The proto-lens-protoc-0.3.1.1 release had an upper bound on `temporary` that was too restrictive. Increase it, and bump the version to `0.3.1.2`. Also fix warnings and improve CI. Turns out the Travis script wasn't robust enough and #195 let through some warnings. I fixed the script and confirmed it now catches such issues. Also bumped the tutorial and bootstrap scripts to the same LTS as the main build.
judah
added a commit
that referenced
this pull request
Aug 28, 2018
* Update changelogs for next 0.3.* release. For: - proto-lens-protoc-0.3.1.1 - proto-lens-protobuf-types-0.3.0.2 * Fix build of proto-lens-0.3.* on lts-12. (#211) Also update `stack.yaml` to `lts-12.6` rather than a nightly. The proto-lens-protoc-0.3.1.1 release had an upper bound on `temporary` that was too restrictive. Increase it, and bump the version to `0.3.1.2`. Also fix warnings and improve CI. Turns out the Travis script wasn't robust enough and #195 let through some warnings. I fixed the script and confirmed it now catches such issues. Also bumped the tutorial and bootstrap scripts to the same LTS as the main build.
avdv
pushed a commit
to avdv/proto-lens
that referenced
this pull request
Aug 9, 2023
* Update changelogs for next 0.3.* release. For: - proto-lens-protoc-0.3.1.1 - proto-lens-protobuf-types-0.3.0.2 * Fix build of proto-lens-0.3.* on lts-12. (google#211) Also update `stack.yaml` to `lts-12.6` rather than a nightly. The proto-lens-protoc-0.3.1.1 release had an upper bound on `temporary` that was too restrictive. Increase it, and bump the version to `0.3.1.2`. Also fix warnings and improve CI. Turns out the Travis script wasn't robust enough and google#195 let through some warnings. I fixed the script and confirmed it now catches such issues. Also bumped the tutorial and bootstrap scripts to the same LTS as the main build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
are back in nightly.
autogenPackageModulesDir#171 is fixed, merge thepersontutorial into a single package(a library with
Proto.*modules and an executable that uses them)and make the instructions in the README match the code.
This change is