Fix README in Person Example #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the patch. The extra Once that patch lands and proto-lens is back in Stackage, I suggest we update the tutorial to use the relevant nightly release. |
|
SGTM |
judah
added a commit
to judah/proto-lens
that referenced
this pull request
May 10, 2018
- Follow-up to google#190: Fix the stack resolver, now that proto-lens and friends are back in nightly. - Fix some broken cross-links. - Now that google#171 is fixed, merge the `person` tutorial into a single package (a library with `Proto.*` modules and an executable that uses them) and make the instructions in the README match the code.
Merged
judah
added a commit
to judah/proto-lens
that referenced
this pull request
May 10, 2018
- Follow-up to google#190: Set an explicit stack resolver, now that proto-lens and friends are back in nightly. - Fix some broken cross-links. - Now that google#171 is fixed, merge the `person` tutorial into a single package (a library with `Proto.*` modules and an executable that uses them) and make the instructions in the README match the code.
judah
added a commit
that referenced
this pull request
May 29, 2018
* Update the tutorials. - Follow-up to #190: Set an explicit stack resolver, now that proto-lens and friends are back in nightly. - Fix some broken cross-links. - Now that #171 is fixed, merge the `person` tutorial into a single package (a library with `Proto.*` modules and an executable that uses them) and make the instructions in the README match the code. * Add proto-lens-protoc as a dependency on the executable. It's not actually needed for Cabal-2.0 (lts-10 or later). But we still have CI for older versions, and it's worth confirming that the example still works on older versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It previously contains some outdated stuff.
This change is