Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'show source [in new tab]' under -lines #912

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix 'show source [in new tab]' under -lines #912

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fa17c0
Fix 'show source [in new tab]' under -lines
tbg Nov 21, 2024
8149a29
Add comment
tbg Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/driver/html/stacks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,9 @@ function stackViewer(stacks, nodes) {
}

// Update params to include src.
let v = pprofQuoteMeta(stacks.Sources[src].FullName);
// When `pprof` is invoked with `-lines`, FullName will be suffixed with `:<line>`,
// which we need to remove.
let v = pprofQuoteMeta(stacks.Sources[src].FullName.replace(/:[0-9]+$/, ''));
if (param != 'f' && param != 'sf') { // old f,sf values are overwritten
// Add new source to current parameter value.
const old = params.get(param);
Expand Down
Loading