Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'show source [in new tab]' under -lines #912

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

tbg
Copy link
Contributor

@tbg tbg commented Nov 21, 2024

With this patch, it's possible to navigate from the (new and now only) flame graph to the source code for a box.

Copy link
Collaborator

@aalexand aalexand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment that explains the "why" behind the regexp? (no need to explain the regexp mechanics itself)

@tbg
Copy link
Contributor Author

tbg commented Nov 29, 2024

Sure, done!

@tbg tbg requested a review from aalexand November 29, 2024 16:52
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.97%. Comparing base (0ed6a68) to head (8149a29).
Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
+ Coverage   66.86%   66.97%   +0.10%     
==========================================
  Files          44       44              
  Lines        9824     9855      +31     
==========================================
+ Hits         6569     6600      +31     
- Misses       2794     2816      +22     
+ Partials      461      439      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tbg
Copy link
Contributor Author

tbg commented Dec 3, 2024

Thanks @aalexand - could you merge?

@aalexand aalexand merged commit 1e3fdc7 into google:main Dec 3, 2024
31 checks passed
@tbg tbg deleted the lines-src branch December 3, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants