Add ShowFrom and HideFrom filters to profile filter lib #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lvng
commented
Apr 16, 2018
lvng
commented
- Added HideFrom and ShowFrom filters.
- They are not yet exposed as command line flags. This change is pretty big so I thought it would be helpful to keep it minimal but I could add that here if desired. I plan to add that in another change.
- Added lots of test cases for interactions between filters, as well as handling of locations with empty lines.
… branch to squash the history.
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 66.64% 66.97% +0.32%
==========================================
Files 36 36
Lines 7448 7528 +80
==========================================
+ Hits 4964 5042 +78
- Misses 2082 2083 +1
- Partials 402 403 +1
Continue to review full report at Codecov.
|
aalexand
reviewed
Apr 17, 2018
| @@ -21,9 +21,19 @@ import "regexp" | |||
| // FilterSamplesByName filters the samples in a profile and only keeps | |||
| // samples where at least one frame matches focus but none match ignore. | |||
| // Returns true is the corresponding regexp matched at least one sample. | |||
| func (p *Profile) FilterSamplesByName(focus, ignore, hide, show *regexp.Regexp) (fm, im, hm, hnm bool) { | |||
| func (p *Profile) FilterSamplesByName(focus, ignore, showFrom, hideFrom, show, hide *regexp.Regexp) (fm, im, sfm, hfm, sm, hm bool) { | |||
There was a problem hiding this comment.
This function has become too complicated now. I would make it a separate function, something like ShowHideFrom and put it to prune.go, next to PruneFrom, since the functionality is rather related to pruning. Having the function separate would make the code and the tests more focused and easier to read.
|
This PR is superseded by #372, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.