-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ShowFrom and HideFrom filters to profile filter lib. #360
Conversation
lvng
commented
Apr 16, 2018
- Added HideFrom and ShowFrom.
- They are not yet exposed as command line flags. This change is pretty big so I thought it would be helpful to keep it minimal but I could add that here if desired.
- Added lots of test cases for interactions between filters, as well as handling of locations with empty lines.
… the beginning of a new, more complicated test. so far is has a test profile and base case.
…rginal profile for comparison.
… for existing filters. finished feedback from first code review.
…how filter when matching mapping and inline functions.
…s may be hidden. formatting.
Could you squash your initial commit history and re-push? It's just noise. |
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
==========================================
+ Coverage 66.64% 66.97% +0.32%
==========================================
Files 36 36
Lines 7448 7528 +80
==========================================
+ Hits 4964 5042 +78
- Misses 2082 2083 +1
- Partials 402 403 +1
Continue to review full report at Codecov.
|
To squash the history I copied changes into a separate PR: #361 |