Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShowFrom and HideFrom filters to profile filter lib. #360

Closed
wants to merge 15 commits into from

Conversation

lvng
Copy link
Contributor

@lvng lvng commented Apr 16, 2018

  • Added HideFrom and ShowFrom.
  • They are not yet exposed as command line flags. This change is pretty big so I thought it would be helpful to keep it minimal but I could add that here if desired.
  • Added lots of test cases for interactions between filters, as well as handling of locations with empty lines.

@aalexand
Copy link
Collaborator

Could you squash your initial commit history and re-push? It's just noise.

@codecov-io
Copy link

Codecov Report

Merging #360 into master will increase coverage by 0.32%.
The diff coverage is 98.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
+ Coverage   66.64%   66.97%   +0.32%     
==========================================
  Files          36       36              
  Lines        7448     7528      +80     
==========================================
+ Hits         4964     5042      +78     
- Misses       2082     2083       +1     
- Partials      402      403       +1
Impacted Files Coverage Δ
internal/driver/driver_focus.go 84.87% <100%> (ø) ⬆️
profile/filter.go 89.61% <98.07%> (+6.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6167805...136ac67. Read the comment docs.

@lvng
Copy link
Contributor Author

lvng commented Apr 16, 2018

To squash the history I copied changes into a separate PR: #361

@lvng lvng closed this Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants