ci: upgrade Codecov to v4 #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #941 +/- ##
==========================================
+ Coverage 63.52% 63.59% +0.06%
==========================================
Files 146 146
Lines 11937 11937
==========================================
+ Hits 7583 7591 +8
+ Misses 3885 3878 -7
+ Partials 469 468 -1 ☔ View full report in Codecov by Sentry. |
|
Ok that's already promising - I'm assuming it worked because PRs for open-source forks don't need an upload token; I'll wait for @another-rex or @oliverchang to confirm the |
Merged
1 task
Ok yup so maybe it will still be broken for direct pushes... |
|
@G-Rath Token has been added now |
oliverchang
approved these changes
Apr 30, 2024
josieang
pushed a commit
to josieang/osv-scanner
that referenced
this pull request
Jun 6, 2024
This will hopefully resolve the issues we're having with the v3 action, but requires the `CODECOV_TOKEN` secret to be configured per [this document](https://docs.codecov.com/docs/adding-the-codecov-token) which needs to be done by someone with repository permissions to set secrets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully resolve the issues we're having with the v3 action, but requires the
CODECOV_TOKENsecret to be configured per this document which needs to be done by someone with repository permissions to set secrets.