-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues uploading Codecov reports #1373
Comments
I think this is an OIDC issue, perhaps if someone on the team can take a look? |
Is there any update on this topic? In case it is a bug, when can we expect a fix? |
@ThomasMeissnerDS I made a suggestion on your PR that should fix the issue. Please note, however, that I still see an error after the Codecov step which you will need to handle. https://github.com/thomasrockhu-codecov/BlueCast/actions/runs/8793108313/job/24130447115?pr=1#step:11:88 |
@thomasrockhu-codecov we've seen this start happening over at google/osv-scanner - we're still on v3 due to how buggy v4 has proven, and coverage has stopped working during April:
https://github.com/google/osv-scanner/actions/runs/8840999640/job/24277388006?pr=943 It looks to be happening on just about every pull request though I think I've seen one where it did upload but didn't produce a comment - that includes pull requests from maintainers and pull requests from forks. Let me know if you'd like a new ticket or any other info. |
@G-Rath have you added the token?
|
@thomasrockhu-codecov we've not changed our configuration at all, and this is the latest version of the v3 action - so the coverage file is still in the same place as it's been for months, and no token has been set since it was never needed in the past. |
@G-Rath, that is all true. However, due to GitHub's rate-limiting policies, we cannot consistently authenticate a repository without the token. |
Ok @thomasrockhu-codecov now we're getting a rate limiting error:
That's on google/osv-scanner#948 where we have the token setup - so I'm not sure what we're meant to do now... |
@G-Rath ahhh I see. I noticed that you are all on |
@thomasrockhu-codecov ok we've officially gotten the token set and upgraded to v4, and everything looks mostly fine now except it looks like there might be some weird flakiness - I've had two instances of our macOS job failing due to the token not being found:
https://github.com/google/osv-scanner/actions/runs/8913635448/job/24479567308 The workflow has been running fine for a bunch of other PRs and on I think it might be that it's not correctly detecting its in a fork - comparing to runs like https://github.com/google/osv-scanner/actions/runs/8903206247/job/24450587696?pr=943, it prints that it is using tokenless upload |
@G-Rath I released a new version |
@thomasrockhu-codecov thanks - we've got pinned actions and I'm not a member of the repo so it'll take probably at least a week before I can confirm for sure if this is working; I'll keep you posted. Also please feel free to get me to open a new "osv-scanner"-based issue at any point - I'm conscious there's a number around that look similar but often have different setups from users, so I'm not sure what the best move is in that regard 😅 |
@G-Rath all good, perhaps we can open a new one if the fix doesn't work out for you to not pollute @ThomasMeissnerDS's issue |
@ThomasMeissnerDS this was been fixed btw, please let me know if it's working for you. |
I see a similar problem using the
I have the upload token configured but I get the |
@leon1995 I think you're looking for this issue |
Hi,
until March 20th my Github actions worked fine and codecov uploaded the test coverage as expected. You can find the workflow file that worked until then here.
Some days ago I started working on a PR and suddenly CodeCov throws an error:
The workflow.yaml stayed unchanged. Also re-trying did not work.
I also tried to follow the quickstart guide and add the environment secret token to GitHub and the yaml and update codecov to version 4 (see here), but I received another error:
What am I doing wrong?
The text was updated successfully, but these errors were encountered: