fix: use correct path separator in SARIF output when on Windows #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
fix/use-windows-path
branch
from
c5f0be6
to
054a666
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1294 +/- ##
==========================================
- Coverage 68.47% 68.41% -0.07%
==========================================
Files 175 175
Lines 16832 16833 +1
==========================================
- Hits 11526 11516 -10
- Misses 4679 4688 +9
- Partials 627 629 +2 ☔ View full report in Codecov by Sentry. |
G-Rath
force-pushed
the
fix/use-windows-path
branch
2 times, most recently
from
5b02b66
to
248ee59
Compare
G-Rath
force-pushed
the
fix/use-windows-path
branch
2 times, most recently
from
e398dd4
to
c2d3627
Compare
G-Rath
force-pushed
the
fix/use-windows-path
branch
from
c2d3627
to
e90407a
Compare
cuixq
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we always output a Unix path separator even when on Windows - this changes us to use the path separator based on the OS.
Resolves #604