Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SARIF reporting should use Windows filepaths #604

Closed
G-Rath opened this issue Oct 24, 2023 · 2 comments · Fixed by #1294
Closed

SARIF reporting should use Windows filepaths #604

G-Rath opened this issue Oct 24, 2023 · 2 comments · Fixed by #1294
Labels
backlog Important but currently unprioritized bug Something isn't working

Comments

@G-Rath
Copy link
Collaborator

G-Rath commented Oct 24, 2023

Currently the SARIF output includes a psuedo path to osv-scanner.toml which is always Unix based even on Windows:

osv-scanner/internal/output/sarif.go

Line 85 in a2c1602

""{{.}}/osv-scanner.toml""

This should be addressed after #603
@hogo6002 hogo6002 added the enhancement New feature or request label Oct 27, 2023
@G-Rath G-Rath added bug Something isn't working and removed enhancement New feature or request labels Oct 31, 2023
@G-Rath G-Rath mentioned this issue Nov 21, 2023
Merged
@github-actions GitHub Actions
Copy link

This issue has not had any activity for 60 days and will be automatically closed in two weeks

@github-actions github-actions bot added the stale The issue or PR is stale and pending automated closure label Jul 20, 2024
@G-Rath G-Rath removed the stale The issue or PR is stale and pending automated closure label Jul 20, 2024
@github-actions GitHub Actions
Copy link

This issue has not had any activity for 60 days and will be automatically closed in two weeks

See https://github.com/google/osv-scanner/blob/main/CONTRIBUTING.md for how to contribute a PR if you're interested in helping out.

@github-actions github-actions bot added the stale The issue or PR is stale and pending automated closure label Sep 18, 2024
@G-Rath G-Rath added backlog Important but currently unprioritized and removed stale The issue or PR is stale and pending automated closure labels Sep 18, 2024
@G-Rath G-Rath mentioned this issue Oct 2, 2024
Merged
@BrewTestBot BrewTestBot mentioned this issue Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Important but currently unprioritized bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use correct path separator in SARIF output when on Windows ackama/osv-scanner
2 participants
@G-Rath @hogo6002