Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KSValueArgumentImpl doesn't implement .equals() in KSP2 #2091

Closed
ZacSweers opened this issue Sep 7, 2024 · 0 comments · Fixed by #2154
Closed

KSValueArgumentImpl doesn't implement .equals() in KSP2 #2091

ZacSweers opened this issue Sep 7, 2024 · 0 comments · Fixed by #2154
Milestone
2.1

Comments

@ZacSweers
Copy link
Contributor

This breaks equality checks when comparison annotations by arguments
This was referenced Sep 7, 2024
Closed
Closed
vRallev added a commit to amzn/kotlin-inject-anvil that referenced this issue Sep 12, 2024
@vRallev
Downgrade Kotlin Compile Testing
72f3e2e 
Due to some incompatibilities we pulled in Kotlin Compile Testing for Kotlin 2.0 and our tests worked. However, we started seeing bugs with KSP2, in particular google/ksp#2091

This project is using Kotlin 1.9, so better also stick with Kotlin Compile Testing and KSP for Kotlin 1.9.
@vRallev vRallev mentioned this issue Sep 12, 2024
Merged
@ZacSweers ZacSweers mentioned this issue Sep 21, 2024
Open
12 tasks
@ting-yuan ting-yuan mentioned this issue Oct 18, 2024
Merged
@ting-yuan ting-yuan added this to the 2.1 milestone Oct 18, 2024
@evant evant mentioned this issue Oct 25, 2024
Open
@vRallev vRallev mentioned this issue Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

KSP2: Implement KSValueArgument.equals ting-yuan/ksp
2 participants
@ZacSweers @ting-yuan