Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Kotlin Compile Testing #32

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Downgrade Kotlin Compile Testing #32

merged 1 commit into from
Sep 12, 2024

Conversation

vRallev
Copy link
Contributor

@vRallev vRallev commented Sep 12, 2024

Due to some incompatibilities we pulled in Kotlin Compile Testing for Kotlin 2.0 and our tests worked. However, we started seeing bugs with KSP2, in particular google/ksp#2091

This project is using Kotlin 1.9, so better also stick with Kotlin Compile Testing and KSP for Kotlin 1.9.

Due to some incompatibilities we pulled in Kotlin Compile Testing for Kotlin 2.0 and our tests worked. However, we started seeing bugs with KSP2, in particular google/ksp#2091

This project is using Kotlin 1.9, so better also stick with Kotlin Compile Testing and KSP for Kotlin 1.9.
@vRallev vRallev marked this pull request as ready for review September 12, 2024 20:23
Base automatically changed from rwo/app-scope to main September 12, 2024 20:54
Copy link

@cahaverl cahaverl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vRallev vRallev merged commit 390114a into main Sep 12, 2024
8 checks passed
@vRallev vRallev deleted the rwo/downgrade branch September 12, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants