Remove Ignore annotation from SnackbarHostTest (#66)

[MohitMandalia]

WHAT

Remove Ignore annotation from SnackbarHostTest

WHY

As the test snackbarHost_returnedResult is not failing @Ignore annotation should be removed

HOW

• Remove @ignore annotation from snackbarHost_returnedResult() and SnackbarHostTest

Checklist 📋

• [] Add explicit visibility modifier and explicit return types for public declarations
• Run spotless check
• Run tests
• Update metalava's signature text files

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[MohitMandalia]

@yschimke sorry I am new to metalava can you suggest me what to do here.

Thanks

[yschimke]

Metalava checks public API, you aren't changing any, so don't worry.

[yschimke]

Failing on this test

com.google.android.horologist.compose.snackbar.SnackbarHostTest > snackbarHost_returnedResult[test(AVD) - 9] FAILED 
	androidx.compose.ui.test.ComposeTimeoutException: Condition still not satisfied after 5000 ms
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment$AndroidComposeUiTestImpl.waitUntil(ComposeUiTest.android.kt:412)

28 and 30 refer to the API versions.

[MohitMandalia]

Yes i'll check

[MohitMandalia]

I tried running the test with API 30 emulator and API 28 both runs fine in the studio but fails in github.

Any issue with the workflow file?

API 28

API 30

[yschimke]

Quite possibly, either the emulators are different, or maybe the config to run tests?

This build runs this

      - name: Run tests
        uses: reactivecircus/android-emulator-runner@v2
        with:
          api-level: ${{ matrix.api-level }}
          target: android-wear
          profile: wear_round_454
          script: ./scripts/run-tests.sh --log-file=logcat.txt --run-affected --affected-base-ref=$BASE_REF --shard-index=${{ matrix.shard }} --shard-count=2

From here https://github.com/google/horologist/blob/main/.github/workflows/build.yml

[MohitMandalia]

still exploring the issues but have found few leads this might be an issue with emulator or config as you said .

ReactiveCircus/android-emulator-runner#53

ReactiveCircus/android-emulator-runner#160

[yschimke]

Thanks for digging into it. If it's not coming to a solution, then I understand if you decide to leave it.

One option might be to rewrite the test using other mechanisms/code paths that might be less flaky.

[MohitMandalia]

I'll try to check few details about the test and that issues I linked if i dont get a solution may be will move on with some other things. Thanks.

[yschimke]

@MohitMandalia Going to close this PR for now, since it's showing issues we need to fix. Please reopen if/when you pick it up again. No problem if you don't intend to either, thanks for taking a look.

[MohitMandalia]

Yes sure i'll reopen it when I start picking up things.😊👍