Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing SnackbarHost test #66

Closed
yschimke opened this issue Apr 6, 2022 · 5 comments
Closed

Failing SnackbarHost test #66

yschimke opened this issue Apr 6, 2022 · 5 comments

Comments

@yschimke
Copy link
Collaborator

yschimke commented Apr 6, 2022 

com.google.android.horologist.compose.snackbar.SnackbarHostTest > snackbarHost_returnedResult[test(AVD) - 11] FAILED 
	androidx.compose.ui.test.ComposeTimeoutException: Condition still not satisfied after 5000 ms
	at androidx.compose.ui.test.AndroidComposeTest.waitUntil(ComposeTest.android.kt:218)

Have disabled for now in #65
@yschimke yschimke mentioned this issue Apr 6, 2022
Merged
@MohitMandalia
Copy link
Contributor

SnackbarHost snackbarHost_returnedResult issue seems to be resolved I ran the test by removing the @Ignore annotation it seems to be passing.

image

@yschimke
Copy link
Collaborator Author

Great, want to put up a PR?

@yschimke
Copy link
Collaborator Author

Please complete https://github.com/google/horologist/blob/main/CONTRIBUTING.md#contributor-license-agreement also

@MohitMandalia
Copy link
Contributor

sure
This issue was already fixed so i'll just remove the @Ignore annotation and make a PR for it.

MohitMandalia pushed a commit to MohitMandalia/horologist that referenced this issue Jul 10, 2022
@mohitmzendrive
Remove ignore annotation for SnackbarHostTest (google#66)
d369316
MohitMandalia pushed a commit to MohitMandalia/horologist that referenced this issue Jul 10, 2022
@mohitmzendrive
Remove ignore annotation for SnackBarHostTest (google#66)
8967dda
MohitMandalia pushed a commit to MohitMandalia/horologist that referenced this issue Jul 10, 2022
@mohitmzendrive
Remove Ignore annotation from SnackbarHostTest (google#66)
fa22825
MohitMandalia pushed a commit to MohitMandalia/horologist that referenced this issue Jul 10, 2022
@mohitmzendrive
Remove Ignore annotation from SnackbarHostTest (google#66)
6b9d207
MohitMandalia added a commit to MohitMandalia/horologist that referenced this issue Jul 10, 2022
@MohitMandalia @mohitmzendrive
Remove Ignore annotation from SnackbarHostTest (google#66)
56b11bd
@yschimke yschimke mentioned this issue Mar 13, 2023
Closed
@yschimke
Copy link
Collaborator Author

Tracking in other bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yschimke @MohitMandalia