-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select one - other] Deselecting "other" option doesn't hide/disable "Other" text #2399
Comments
@gino-m do you have a screenshot of what you're referring to? |
Sure! Just added to the description above. |
@gino-m thank you! I feel like it makes sense to only have the other option text field to show up when someone selects other. That way if they choose option a or b the other text field just disappears cc: @vittorino for his thoughts |
Hello @gino-m, Can I work on this issue? Thanks, |
Yes, please! Can you also verify this is still occurring? |
Hi @gino-m, Thank you! I just verified that the issue is still occurring. Please find the attached screen recording for reference. Screen_recording_20240603_140323.mp4To confirm, the expected functionality is that the text box should only be shown when the "Other" option is selected. If the user selects options A or B, the text box should hide. Is that correct, or should the text box be in a disabled state when the user selects options A or B? Looking forward to your input to ensure I'm moving in the right direction. Best, |
Thank you for confirming.
Good question. I think the "Other" behavior should actually be as follows:
Please let me know if you have any other questions! |
Thank you for clarifying! I will have a PR up by Wednesday. |
Hello Gino, Sorry for the delayed response. I checked the current implementation, and the behavior seems correct—entering text into the "Other" textbox selects the "Other" option, and the response is not sent if the "Other" option is not selected. I observed that the keyboard stays up if we select the "Other" option and then select a different option. Should we make the keyboard hide in this case? Looking forward to your direction 😊 Best, |
Focus from the "other" text should also be removed once any other option is selected. |
Fixed this issue: Disabling "other" option doesn't hide/disable "Other" text
Hello @gino-m & @shobhitagarwal1612, Thank you for your guidance! I have just raised PR #2528 for this issue. Please review it and provide your feedback. Thanks, |
When "other" option is disabled, either by clicking another radio box (select one) or by deselected the "other" checkbox (select many), the other text remains visible in the UI,
@rawbzz @vittorino What is the expected behavior here? @justinkimtang FYI
Screen_recording_20240322_160349.webm
The text was updated successfully, but these errors were encountered: