Fixed issue google#2399

Fixed this issue: Disabling "other" option doesn't hide/disable "Other" text
NudurupatiSurya · Jun 28, 2024 · 8186ac9 · 8186ac9
1 parent 1ef7dea
commit 8186ac9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/...ogle/android/ground/ui/datacollection/tasks/multiplechoice/MultipleChoiceTaskViewModel.kt b/...ogle/android/ground/ui/datacollection/tasks/multiplechoice/MultipleChoiceTaskViewModel.kt
@@ -147,6 +147,9 @@ class MultipleChoiceTaskViewModel @Inject constructor(resources: Resources) :
     }
   }
 
+  fun isOtherOptionAndSelected(item: MultipleChoiceItem): Boolean =
+    item.isOtherOption && item.isSelected
+
   companion object {
     private const val OTHER_ID: String = "OTHER_ID"
     private const val OTHER_PREFIX: String = "[ "

diff --git a/ground/src/main/res/layout/multiple_choice_radiobutton_item.xml b/ground/src/main/res/layout/multiple_choice_radiobutton_item.xml
@@ -64,6 +64,7 @@
         android:inputType="text"
         android:text="@{item.otherText}"
         android:visibility="@{item.isOtherOption ? View.VISIBLE: View.GONE}"
+        android:enabled="@{viewModel.isOtherOptionAndSelected(item)}"
         app:textChangedListener="@{viewModel.otherTextWatcher}" />
     </com.google.android.material.textfield.TextInputLayout>
   </androidx.constraintlayout.widget.ConstraintLayout>