Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert oss_fuzz_corpus typo fix #1997

Merged
merged 1 commit into from
Jun 13, 2024
Merged

revert oss_fuzz_corpus typo fix #1997

merged 1 commit into from
Jun 13, 2024

Conversation

ndrewh
Copy link
Contributor

@ndrewh ndrewh commented Jun 12, 2024

This reverts #1993

the comments in experiment-requests.yml are untouchable without breaking tests

@ndrewh
Copy link
Contributor Author

ndrewh commented Jun 12, 2024

🤬 presubmit failed

@ndrewh
Copy link
Contributor Author

ndrewh commented Jun 12, 2024

Alright, I changed it to just touch the comments in experiment-requests.yml, and it still breaks tests. So i'm giving up on fixing the typo. Just reverting

@ndrewh ndrewh changed the title Normalize to use oss_fuzz_corpus instead of oss-fuzz-corpus revert oss_fuzz_corpus typo fix Jun 12, 2024
@DonggeLiu
Copy link
Contributor

DonggeLiu commented Jun 13, 2024

Thanks for creating this, @ndrewh.
May I ask if experiment-requests.yml is the only source of error when unifying the -s and _s?

I reckon there is no need to rewrite experiment-requests.yml: it will not be used/parsed/revived anytime soon.

For example, if we do a universal grep and replace to only use oss_fuzz_corpus (or oss-fuzz-corpus) expect experiment-requests.yml, would that still have CI failures?

@ndrewh
Copy link
Contributor Author

ndrewh commented Jun 13, 2024

Yes it is the only issue and yes it has CI failures if you try to fix

@DonggeLiu
Copy link
Contributor

I see, that's really weird.

Sorry that it did not work out this time, but thanks again for your time.
Let me merge this for now.

@DonggeLiu DonggeLiu merged commit aec0123 into google:master Jun 13, 2024
3 checks passed
@jonathanmetzman
Copy link
Contributor

Dongge I think we can just delete the test and reland.

jonathanmetzman added a commit that referenced this pull request Jun 20, 2024
jonathanmetzman added a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants