-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix saturated corpus experiment requests #1993
Conversation
Experiment request docs say to use oss-fuzz-corpus, not oss_fuzz_corpus
Alternatively, we could just change the yaml to use the underscore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BTW note that we don't use experiment-requests.yaml. Experiments are conducted through "gcbrun" commands in PRs. |
@ndrewh Sorry I just noticed that your commit failed the presubmit test, could you please fix it? Thanks! |
This reverts commit 0f85b4a.
This reverts #1993 the comments in experiment-requests.yml are untouchable without breaking tests
The parser for experiment-requests.yml checks
oss_fuzz_corpus
:fuzzbench/service/automatic_run_experiment.py
Lines 64 to 67 in 421187b
Experiment request docs say to use
oss-fuzz-corpus
, notoss_fuzz_corpus
fuzzbench/service/experiment-requests.yaml
Line 9 in 421187b
and all the past experiment requests are using
oss-fuzz-corpus
fuzzbench/service/experiment-requests.yaml
Lines 2273 to 2276 in 421187b