Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saturated corpus experiment requests #1993

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

ndrewh
Copy link
Contributor

@ndrewh ndrewh commented May 29, 2024

The parser for experiment-requests.yml checks oss_fuzz_corpus:

def _use_oss_fuzz_corpus(experiment_config: dict) -> bool:
"""Returns the oss_fuzz_corpus flag of the experiment described by
|experiment_config| as a bool."""
return bool(experiment_config.get('oss_fuzz_corpus'))

Experiment request docs say to use oss-fuzz-corpus, not oss_fuzz_corpus

# # oss-fuzz-corpus: true # Set to use latest saturated corpora from OSS-Fuzz.

and all the past experiment requests are using oss-fuzz-corpus

- experiment: 2021-07-15-saturated
description: "Benchmark a new experimental feature for AFL++ (saturated)"
type: bug
oss-fuzz-corpus: true

Experiment request docs say to use oss-fuzz-corpus, not oss_fuzz_corpus
@ndrewh
Copy link
Contributor Author

ndrewh commented May 29, 2024

Alternatively, we could just change the yaml to use the underscore

Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanmetzman jonathanmetzman merged commit 0f85b4a into google:master Jun 4, 2024
2 of 3 checks passed
@jonathanmetzman
Copy link
Contributor

BTW note that we don't use experiment-requests.yaml. Experiments are conducted through "gcbrun" commands in PRs.

@DonggeLiu
Copy link
Contributor

@ndrewh Sorry I just noticed that your commit failed the presubmit test, could you please fix it?

Thanks!

DonggeLiu added a commit that referenced this pull request Jun 7, 2024
DanBlackwell added a commit to DanBlackwell/fuzzbench that referenced this pull request Jun 7, 2024
ndrewh added a commit to ndrewh/fuzzbench that referenced this pull request Jun 12, 2024
DonggeLiu pushed a commit that referenced this pull request Jun 13, 2024
This reverts #1993

the comments in experiment-requests.yml are untouchable without breaking
tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants