Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation material failure log #8317

Merged
merged 2 commits into from
Dec 18, 2024
+2 −2
Merged

Fix compilation material failure log #8317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be52e53
Fix compilation material failure log
poweifeng Dec 17, 2024
1c74738
Merge branch 'main' into pf/material-better-log
poweifeng Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions filament/src/details/Material.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ Program FMaterial::getProgramWithVariants(
<< "The material '" << mName.c_str()
<< "' has not been compiled to include the required GLSL or SPIR-V chunks for the "
"vertex shader (variant="
<< variant.key << ", filtered=" << vertexVariant.key << ").";
<< +variant.key << ", filtered=" << +vertexVariant.key << ").";

/*
* Fragment shader
Expand All @@ -571,7 +571,7 @@ Program FMaterial::getProgramWithVariants(
<< "The material '" << mName.c_str()
<< "' has not been compiled to include the required GLSL or SPIR-V chunks for the "
"fragment shader (variant="
<< variant.key << ", filtered=" << ").";
<< +variant.key << ", filtered=" << +fragmentVariant.key << ").";

Program program;
program.shader(ShaderStage::VERTEX, vsBuilder.data(), vsBuilder.size())
Expand Down
Loading