Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation material failure log #8317

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fix compilation material failure log #8317

merged 2 commits into from
Dec 18, 2024

Conversation

poweifeng
Copy link
Contributor

No description provided.

@poweifeng poweifeng added the internal Issue/PR does not affect clients label Dec 17, 2024
pixelflinger
pixelflinger approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@pixelflinger pixelflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've been using the +value syntax instead of (int)value; it's the same, but a bit more compact.

@poweifeng poweifeng force-pushed the pf/material-better-log branch from b8e6749 to be52e53 Compare December 18, 2024 00:12
@poweifeng
Copy link
Contributor Author

LGTM. I've been using the +value syntax instead of (int)value; it's the same, but a bit more compact.

updated

@poweifeng poweifeng enabled auto-merge (squash) December 18, 2024 00:14
@poweifeng poweifeng merged commit 8ddc4d3 into main Dec 18, 2024
12 checks passed
@poweifeng poweifeng deleted the pf/material-better-log branch December 18, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bejado bejado bejado approved these changes

@pixelflinger pixelflinger pixelflinger approved these changes

@z3moon z3moon Awaiting requested review from z3moon

Assignees
No one assigned
Labels
internal Issue/PR does not affect clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poweifeng @pixelflinger @bejado