doc: fix viewer page again #7254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
poweifeng
commented
Oct 10, 2023
poweifeng
commented
- reverse the link and original relationship between docs/viewer/filament-viewer.js and web/filament-js/filament-viewer.js
- symlink in github pages does not seem to link to outside of the /doc directory (it does not get pulled in during deploy).
- reverse the link and original relationship between docs/viewer/filament-viewer.js and web/filament-js/filament-viewer.js - symlink in github pages does not seem to link to outside of the /doc directory (it does not get pulled in during deploy).
pixelflinger
approved these changes
Oct 10, 2023
plepers
pushed a commit
to plepers/filament
that referenced
this pull request
Dec 9, 2023
- reverse the link and original relationship between docs/viewer/filament-viewer.js and web/filament-js/filament-viewer.js - symlink in github pages does not seem to link to outside of the /doc directory (it does not get pulled in during deploy).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.