Moe Sync #1263
Moe Sync #1263
Conversation
…ce newer versions of Mockito moved those methods. RELNOTES: FormatStringAnnotation checker will recognize invocations to org.mockito.ArgumentMatchers members as substitutions for constant format strings. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=243826694
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=243851753
Fixes #1259, fixes #1238 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=243966733
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=244028884
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=244045818
WARNING: crash in Error Prone analyzer InvalidThrows [CONTEXT ratelimit_period="5 SECONDS" analyzer="Javadoc" ] java.lang.NullPointerException at com.google.errorprone.bugpatterns.javadoc.InvalidThrows$ThrowsChecker.visitThrows(InvalidThrows.java:78) at com.google.errorprone.bugpatterns.javadoc.InvalidThrows$ThrowsChecker.visitThrows(InvalidThrows.java:62) at jdk.compiler/com.sun.tools.javac.tree.DCTree$DCThrows.accept(DCTree.java:871) at jdk.compiler/com.sun.source.util.DocTreePathScanner.scan(DocTreePathScanner.java:71) ... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=244089578
…ne plugins This checker is opensourced at mockito/mockito#1690 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=244160840
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Adds org.mockito.ArgumentMatchers to StringFormatStringValidation since newer versions of Mockito moved those methods.
RELNOTES: FormatStringAnnotation checker will recognize invocations to org.mockito.ArgumentMatchers members as substitutions for constant format strings.
12ba9de
Fix handling of test protos
c6370e8
Bundle Guava's failureaccess in the with-dependencies JAR
Fixes #1259, fixes #1238
5fb1fc5
Disable tests that don't work in open source
c26ae46
Reflect support for getTimeZone(ZoneId) in AndroidJdkLibsChecker
6856d2f
Fix stack trace logged during a build error.
WARNING: crash in Error Prone analyzer InvalidThrows [CONTEXT ratelimit_period="5 SECONDS" analyzer="Javadoc" ]
java.lang.NullPointerException
at com.google.errorprone.bugpatterns.javadoc.InvalidThrows$ThrowsChecker.visitThrows(InvalidThrows.java:78)
at com.google.errorprone.bugpatterns.javadoc.InvalidThrows$ThrowsChecker.visitThrows(InvalidThrows.java:62)
at jdk.compiler/com.sun.tools.javac.tree.DCTree$DCThrows.accept(DCTree.java:871)
at jdk.compiler/com.sun.source.util.DocTreePathScanner.scan(DocTreePathScanner.java:71)
...
a483644
Move MockitoInternalUsage checker to the Mockito open source errorprone plugins
This checker is opensourced at mockito/mockito#1690
824f573