Reflect support for getTimeZone(ZoneId) in AndroidJdkLibsChecker

------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=244045818
google · Apr 18, 2019 · 6856d2f · 6856d2f
1 parent c26ae46
commit 6856d2f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/apidiff/AndroidJdkLibsChecker.java b/core/src/main/java/com/google/errorprone/bugpatterns/apidiff/AndroidJdkLibsChecker.java
@@ -177,6 +177,7 @@ private boolean memberIsWhitelisted(Entry<String, ClassMemberKey> member) {
             .put("java/util/Arrays", ClassMemberKey.create("stream", ""))
             .put("java/util/Date", ClassMemberKey.create("from", ""))
             .put("java/util/GregorianCalendar", ClassMemberKey.create("from", ""))
+            .put("java/util/TimeZone", ClassMemberKey.create("getTimeZone", ""))
             .put("java/lang/Integer", ClassMemberKey.create("sum", ""))
             .put("java/lang/Long", ClassMemberKey.create("sum", ""))
             .put("java/lang/Double", ClassMemberKey.create("sum", ""))

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/apidiff/AndroidJdkLibsCheckerTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/apidiff/AndroidJdkLibsCheckerTest.java
@@ -146,4 +146,20 @@ public void allowJava8Flag_memberBlacklist() {
             "}")
         .doTest();
   }
+
+  @Test
+  public void allowJava8Flag_getTimeZone() {
+    allowJava8Helper
+        .addSourceLines(
+            "Test.java",
+            "import java.time.ZoneId;",
+            "import java.util.TimeZone;",
+            "public class Test {",
+            "  public static void test() {",
+            "    TimeZone.getTimeZone(\"a\");",
+            "    TimeZone.getTimeZone(ZoneId.of(\"a\"));",
+            "  }",
+            "}")
+        .doTest();
+  }
 }