Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moe Sync #1082

Merged
merged 13 commits into from
Aug 6, 2018
Merged

Moe Sync #1082

merged 13 commits into from
Aug 6, 2018

Commits on Aug 6, 2018

  1. Fix bug introduced when migrating Unused.

    Using foo.accept() rather than scan() to progress down the tree breaks TreePathScanner's tracking of TreePath. Added test to validate.
    
    RELNOTES: N/A
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=207058173
    graememorgan authored and ronshapiro committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    4aff494 View commit details
    Browse the repository at this point in the history
  2. Make ProtoStringFieldReferenceEquality match Lite protos too.

    RELNOTES: N/A
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=207058949
    graememorgan authored and ronshapiro committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    ae82dab View commit details
    Browse the repository at this point in the history
  3. Stop EqualsGetClass from matching unless getClass is used on the inco…

    …ming parameter.
    
    RELNOTES: N/A
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=207237033
    graememorgan authored and ronshapiro committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    26325be View commit details
    Browse the repository at this point in the history
  4. Prevent UnnecessaryParentheses false-positiving on compile-time-const…

    …ant String expressions.
    
    RELNOTES: N/A
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=207260298
    graememorgan authored and ronshapiro committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    3f9df16 View commit details
    Browse the repository at this point in the history
  5. Make ProtoRedundantSet generate a match per occurrence on the offendi…

    …ng line, rather than a large mashed-together match at the end of the entire chain.
    
    RELNOTES: Improve suggestion of ProtoRedundantSet.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=207260573
    graememorgan authored and ronshapiro committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    b52f35f View commit details
    Browse the repository at this point in the history
  6. Generate bugpattern links before tables

    RELNOTES: N/A
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=207263348
    cushon authored and ronshapiro committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    59a2dd3 View commit details
    Browse the repository at this point in the history
  7. Consolidate static #equals matchers.

    And fix a javadoc.
    
    RELNOTES: N/A
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=207264130
    graememorgan authored and ronshapiro committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    e74aee3 View commit details
    Browse the repository at this point in the history
  8. Typo fixed: Nullabe -> Nullable

    Fixes #1077
    
    RELNOTES: N/A
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=207278809
    amaembo authored and ronshapiro committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    cab7ec5 View commit details
    Browse the repository at this point in the history
  9. BadImport: ignore enum case labels when the identifier is otherwise s…

    …tatically imported
    
    RELNOTES: Ignore enum case labels in BadImport check
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=207349366
    awturner authored and ronshapiro committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    399a067 View commit details
    Browse the repository at this point in the history
  10. Add missing doTest()s.

    RELNOTES: N/A
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=207501124
    graememorgan authored and ronshapiro committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    7830b2e View commit details
    Browse the repository at this point in the history
  11. Enable ProtoStringFieldReferenceEquality as an error.

    RELNOTES: N/A
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=207519142
    graememorgan authored and ronshapiro committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    7f478f5 View commit details
    Browse the repository at this point in the history
  12. Update the Refaster rule build instructions

    Update the Refaster rule build instructions
    to match the ones on the web site. Remove
    no longer needed `J--add-exports` compiler
    options.
    
    See also:
     - 0ede1de
     - #1078
    
    Fixes #1079
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=207543845
    dmitry-timofeev authored and ronshapiro committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    654aba4 View commit details
    Browse the repository at this point in the history
  13. Make UndefinedEquals match Truth's is(Not)?EqualTo as well as JUnit a…

    …ssertions with messages.
    
    RELNOTES: N/A
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=207559362
    graememorgan authored and ronshapiro committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    077f372 View commit details
    Browse the repository at this point in the history