Moe Sync #1082
Merged
Moe Sync #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using foo.accept() rather than scan() to progress down the tree breaks TreePathScanner's tracking of TreePath. Added test to validate. RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207058173
RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207058949
…ming parameter. RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207237033
…ant String expressions. RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207260298
…ng line, rather than a large mashed-together match at the end of the entire chain. RELNOTES: Improve suggestion of ProtoRedundantSet. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207260573
RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207263348
And fix a javadoc. RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207264130
Fixes #1077 RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207278809
…tatically imported RELNOTES: Ignore enum case labels in BadImport check ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207349366
RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207501124
RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207519142
Update the Refaster rule build instructions to match the ones on the web site. Remove no longer needed `J--add-exports` compiler options. See also: - 0ede1de - #1078 Fixes #1079 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207543845
…ssertions with messages. RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207559362
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Fix bug introduced when migrating Unused.
Using foo.accept() rather than scan() to progress down the tree breaks TreePathScanner's tracking of TreePath. Added test to validate.
RELNOTES: N/A
4aff494
Make ProtoStringFieldReferenceEquality match Lite protos too.
RELNOTES: N/A
ae82dab
Stop EqualsGetClass from matching unless getClass is used on the incoming parameter.
RELNOTES: N/A
26325be
Prevent UnnecessaryParentheses false-positiving on compile-time-constant String expressions.
RELNOTES: N/A
3f9df16
Make ProtoRedundantSet generate a match per occurrence on the offending line, rather than a large mashed-together match at the end of the entire chain.
RELNOTES: Improve suggestion of ProtoRedundantSet.
b52f35f
Generate bugpattern links before tables
RELNOTES: N/A
59a2dd3
Consolidate static #equals matchers.
And fix a javadoc.
RELNOTES: N/A
e74aee3
Typo fixed: Nullabe -> Nullable
Fixes #1077
RELNOTES: N/A
cab7ec5
BadImport: ignore enum case labels when the identifier is otherwise statically imported
RELNOTES: Ignore enum case labels in BadImport check
399a067
Add missing doTest()s.
RELNOTES: N/A
7830b2e
Enable ProtoStringFieldReferenceEquality as an error.
RELNOTES: N/A
7f478f5
Update the Refaster rule build instructions
Update the Refaster rule build instructions
to match the ones on the web site. Remove
no longer needed
J--add-exportscompileroptions.
See also:
Fixes #1079
654aba4
Make UndefinedEquals match Truth's is(Not)?EqualTo as well as JUnit assertions with messages.
RELNOTES: N/A
077f372