Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fr: Updating French translation file, and a few messages. #743

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

yohcop
Copy link
Contributor

@yohcop yohcop commented Jun 1, 2023

Re-generated a new po/messages.pot, and merged into po/fr.po.

Updated a handful of message translations as well, but this small PR is mostly to 'get my feet wet' with the whole process.

Part of #323.

@yohcop yohcop requested review from sakex and lb034582341 as code owners June 1, 2023 09:30
@mgeisler mgeisler changed the title Updating french translation file, and a few messages. fr: Updating French translation file, and a few messages. Jun 1, 2023
@mgeisler
Copy link
Collaborator

mgeisler commented Jun 1, 2023

Thanks @yohcop! I added a reference to the French translation issue (that way the PR shows up on the issue).

@yohcop
Copy link
Contributor Author

yohcop commented Jun 1, 2023

I'm not sure if I did this right. The file is so big, as most line numbers have changed, that github doesn't want to load the diff. Let me know if I should do things differently.

Copy link
Collaborator

@sakex sakex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge CL, we can merge it like this for now. I will have a longer look on this next week

@sakex
Copy link
Collaborator

sakex commented Jun 1, 2023

Also, it doesn't let me add my review comments for some reason

@mgeisler
Copy link
Collaborator

mgeisler commented Jun 1, 2023

I'm not sure if I did this right. The file is so big, as most line numbers have changed, that github doesn't want to load the diff. Let me know if I should do things differently.

You did it right! The problem is that msgmerge formats the PO file differently than our mdbook-xgettext plugin. I should fix that so I filed google/mdbook-i18n-helpers#32 for it.

@mgeisler mgeisler merged commit 7041fc6 into google:main Jun 1, 2023
@mgeisler
Copy link
Collaborator

mgeisler commented Jun 1, 2023

I merged this, thanks for looking it over!

@sakex, you should generally merge PRs when approving them since most people won't have write access to the repository.

NoahDragon pushed a commit to wnghl/comprehensive-rust that referenced this pull request Jul 19, 2023
Updating french translation file, and a few messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants