Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-CN: Day 1 Translations #1245

Closed
wants to merge 0 commits into from
Closed

zh-CN: Day 1 Translations #1245

wants to merge 0 commits into from

Conversation

henrif75
Copy link
Collaborator

Add professional translations for missing day 1 entries. Chinese (Simplified) translation #324

@henrif75 henrif75 closed this Sep 24, 2023
@henrif75 henrif75 changed the title zh-CN: Day 2 Translations zh-CN: Day 1 Translations Sep 24, 2023
@henrif75 henrif75 reopened this Sep 24, 2023
@henrif75
Copy link
Collaborator Author

PS: Commit description is for day 1

@henrif75 henrif75 marked this pull request as ready for review September 24, 2023 20:36
@emmali01 emmali01 self-requested a review September 26, 2023 04:40
mgeisler added a commit to google/mdbook-i18n-helpers that referenced this pull request Oct 2, 2023
This will reduce churn between the output of `mdbook-xgettext` and
`msgmerge`. See google/comprehensive-rust#1245
for an example PR which would shrink with this feature.

Part of #32, but we still have differences in the way the messages
themselves are wrapped.
@henrif75 henrif75 enabled auto-merge (squash) October 3, 2023 03:54
@henrif75 henrif75 marked this pull request as draft October 4, 2023 04:11
auto-merge was automatically disabled October 4, 2023 04:11

Pull request was converted to draft

@mgeisler
Copy link
Collaborator

mgeisler commented Oct 6, 2023

Ah, this now have a conflict...

% gh pr diff 1245 | diffstat                                                                                   (~/src/comprehensive-rust)
 zh-CN.po |20591 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 20479 insertions(+), 112 deletions(-)

Since it inserts 20k lines, perhaps this is where the lost lines from #1242 went? 😄 It should be easy to fix, just fish out the latest zh-CN.po file from main and combine them with msgmerge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants