Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh_CN: .po refresh and remaining course intro translations #1242

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

henrif75
Copy link
Collaborator

@henrif75 henrif75 commented Sep 24, 2023

Normalizes .po file and add professional translation to missing entries before day 1.
#324

@henrif75
Copy link
Collaborator Author

There are fuzzy entries that can be checked after this is merged.

@henrif75 henrif75 requested a review from emmali01 as a code owner September 29, 2023 18:32
@henrif75 henrif75 merged commit 86cde61 into google:main Sep 29, 2023
@henrif75 henrif75 deleted the zh-CN branch September 29, 2023 18:38
@henrif75
Copy link
Collaborator Author

Thank you @kongy!

@mgeisler
Copy link
Collaborator

mgeisler commented Oct 3, 2023

Hi @henrif75 and @kongy, I think something went wrong here since a lot of translated messages disappeared. Compare these two test runs:

I tried checking out 1a1a9c8 and ran msgmerge --update. There are still 1187 translated messages after this, so the problem is not simply that lots of stuff changes in the English version.

Please take the old zh-CN.po file and combine it with the current version using msgcat and then run msgmerge on the result. That should help restore the old translations that still work.

@henrif75
Copy link
Collaborator Author

henrif75 commented Oct 3, 2023

I agree, it's weird. I guess there was too many PRs at different baselines. I'm going to pull out the open zh-CN PRs and re-merge the translated entries.

@mgeisler
Copy link
Collaborator

mgeisler commented Oct 4, 2023

I agree, it's weird. I guess there was too many PRs at different baselines. I'm going to pull out the open zh-CN PRs and re-merge the translated entries.

Okay, let me know if you run into problems! A quick

msgfmt -o /dev/null --statistics po/zh-CN.po

should tell you the state of the file after the surgery 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants